Tags: Add support for comma separation for multipart forms (import/reimport)#12434
Merged
Conversation
|
This pull request introduces potential tag parsing vulnerabilities in the code that could allow unexpected tag processing and might create security risks during tag validation and import processes. 💭 Unconfirmed Findings (2)
All finding details can be found in the DryRun Security Dashboard. |
Maffooch
changed the title
valentijnscholten
requested changes
May 12, 2025
Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
valentijnscholten
approved these changes
May 13, 2025
hblankenship
approved these changes
May 13, 2025
dogboat
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to attach multiple tags during a reimport through the swagger docs page, the curl request that is generated places all submitted tags in the same form field in a comma separated list. In the recent changes from #1294, commas are not longer allowed. This PR allowed for tag enforcement in lists, but not when a string is passed. Unfortunately correcting the generated curl request is not really feasible, so we must return to approach of splitting all tags from the API by commas.
Slack Context: https://defectdojo-workspace.slack.com/archives/C2P5BA8MN/p1747055360228049
[sc-11116]